-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] make enum part of cluster wheel #26740
Merged
andy31415
merged 2 commits into
project-chip:master
from
agners:make-enum-part-of-clusters-wheel
May 25, 2023
Merged
[python] make enum part of cluster wheel #26740
andy31415
merged 2 commits into
project-chip:master
from
agners:make-enum-part-of-clusters-wheel
May 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelveldt
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR #26740: Size comparison from 1efbaf6 to 53d8978 Increases (8 builds for cc32xx, cyw30739, efr32, telink)
Decreases (10 builds for bl702, cyw30739, efr32, esp32, nrfconnect, psoc6, telink)
Full report (45 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
The new enum type is required in the Cluster objects. Make it and its dependency part of the Cluster CHIP wheel. Fixes PR project-chip#24352.
agners
force-pushed
the
make-enum-part-of-clusters-wheel
branch
from
May 23, 2023 12:13
53d8978
to
d648edb
Compare
PR #26740: Size comparison from d1d37ec to d648edb Increases (7 builds for cc32xx, k32w, nrfconnect, telink)
Decreases (13 builds for bl602, efr32, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 23, 2023
@agners Note restyled failure. |
pullapprove
bot
requested review from
amitnj,
arkq,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
kcoppock
May 24, 2023 06:20
pullapprove
bot
requested review from
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
kcoppock,
kkasperczyk-no,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
vijs,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 24, 2023 06:20
jmartinez-silabs
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new enum type is required in the Cluster objects. Make it and its dependency part of the Cluster CHIP wheel.
Fixes PR #24352.